Adds Immerse to Showcase #8284
Adds Immerse to Showcase #8284
Conversation
Adds Immerse to showcase - a React Native WebRTC app for daily language practice.
|
By analyzing the blame information on this pull request, we identified @brentvatne and @manonthemat to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
A big overhaul to the showcase page is happening with #8263 --- so I want to land that first and then this will have to be rebased on top of that. |
|
cc @lacker |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
|
Verbling seems like a good showcase candidate. We need a link to some sort of useful news or something though. Maybe just https://www.crunchbase.com/organization/verbling#/entity - did you guys do any PR around the launch of Immerse? |
|
@markthom-as #8263 has landed. So this pull request can be rebased and updated on top of that. |
ghost
added
the
CLA Signed
|
@markthom-as do you have any updates for this pull request? It's been a while since the last update so wanted to check in and see if you've looked at the requested changes. |
ghost
added
the
CLA Signed
|
@markthom-as I'm going through all pull requests and noticed this one hasn't been updated in a while and the last comment asks a question. I'll close this pull request so it doesn't stay open indefinitely but please send a new one if you want to add Immerse to the showcase. |
The PR reworks history integration to better integrate with browser's history stack and supports nested navigation more reliably: - On each navigation, save the navigation in memory and use it to reset the state when user presses back/forward - Improve heuristic to determine if we should do a push, replace or back This closes facebook#8230, closes facebook#8284 and closes facebook#8344
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
(You can skip this if you're fixing a typo or adding an app to the Showcase.)
Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.
Adds Immerse to showcase - a React Native WebRTC app for daily language practice.